Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(native): add note about setting user for native release health user stats #8661

Merged
merged 2 commits into from
Dec 13, 2023
Merged

fix(native): add note about setting user for native release health user stats #8661

merged 2 commits into from
Dec 13, 2023

Conversation

kahest
Copy link
Member

@kahest kahest commented Dec 7, 2023

@vercel Vercel
Copy link

vercel bot commented Dec 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 5:18pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
sentry-docs-next ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2023 5:18pm

lizokm
lizokm reviewed Dec 12, 2023
View reviewed changes
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This note isn't showing up in the preview for some reason...

@kahest
Copy link
Member Author

kahest commented Dec 13, 2023

This note isn't showing up in the preview for some reason...

I see it here: https://sentry-docs-git-kahest-native-user-release-health-hint.sentry.dev/platforms/native/enriching-events/identify-user

Screenshot 2023-12-13 at 11 21 30

lizokm
lizokm approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@lizokm lizokm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the note now. That's what I get for trying to look at PRs when I have a fever ;p Made a small tweak, but otherwise this looks good.

src/platform-includes/enriching-events/set-user/native.mdx Outdated Show resolved Hide resolved
@kahest @lizokm
Update src/platform-includes/enriching-events/set-user/native.mdx
daf1345 
Co-authored-by: Liza Mock <liza.mock@sentry.io>
@kahest kahest merged commit 30e4173 into master Dec 13, 2023
9 checks passed
@kahest kahest deleted the kahest/native-user-release-health-hint branch December 13, 2023 17:35
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lizokm lizokm lizokm approved these changes

@markushi markushi Awaiting requested review from markushi

@shanamatthews shanamatthews Awaiting requested review from shanamatthews

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using sentry_set_user but no users show up in dashboards
2 participants
@kahest @lizokm